Skip to content

[PRMP-1213] Forward OPTIONS requests in edge lambda #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamwhitingnhs merged 2 commits into from
Jan 8, 2026
Merged

[PRMP-1213] Forward OPTIONS requests in edge lambda #988

adamwhitingnhs merged 2 commits into from
Jan 8, 2026
+17 −2

Conversation

@adamwhitingnhs
Copy link
Contributor

@adamwhitingnhs adamwhitingnhs commented Jan 7, 2026 •
edited
Loading

Overview

https://nhsd-jira.digital.nhs.uk/browse/PRMP-1213

Description

Modify the edge lambda handler to return the request if the method is OPTIONS.

Context

Currently the edge lambda will handle OPTIONS requests as well as GET/PUT. We don't want it to actually process OPTIONS requests, so we need to return them immediately to be forwarded to S3.

Checklist

Tasks for all changes:

  • 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits. (WIP)
  • 3. I have added and/or updated relevant tests.
  • 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:

@adamwhitingnhs adamwhitingnhs requested review from a team as code owners January 7, 2026 17:31
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Code security issues found

View full details here.

@adamwhitingnhs adamwhitingnhs enabled auto-merge (squash) January 8, 2026 15:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@adamwhitingnhs adamwhitingnhs merged commit 135103a into main Jan 8, 2026
18 of 19 checks passed
@adamwhitingnhs adamwhitingnhs deleted the PRMP-1213 branch January 8, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SWhyteAnswer SWhyteAnswer SWhyteAnswer approved these changes

@MohammadIqbalAD-NHS MohammadIqbalAD-NHS MohammadIqbalAD-NHS approved these changes

@NogaNHS NogaNHS NogaNHS approved these changes

@steph-torres-nhs steph-torres-nhs steph-torres-nhs approved these changes

@SteveMahoneyNHS SteveMahoneyNHS Awaiting requested review from SteveMahoneyNHS SteveMahoneyNHS is a code owner automatically assigned from NHSDigital/access-store

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@adamwhitingnhs @SWhyteAnswer @MohammadIqbalAD-NHS @NogaNHS @steph-torres-nhs @bethany-kish-nhs